Darwin: promote Cooking Appliances to Introduced #33399
Open
+557
−1,562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33399: Size comparison from 0d67568 to e7bf019 Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
kiel-apple
force-pushed
the
darwin-cooking-appliances-introduction
branch
from
e7bf019
to
3265394
Compare
|
PR #33399: Size comparison from 0180ee6 to 3265394 Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
kiel-apple
force-pushed
the
darwin-cooking-appliances-introduction
branch
from
3265394
to
fe2bbe1
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
bzbarsky-apple
requested changes
Oct 25, 2024
|
@bzbarsky-apple thanks for checking the spec, I could have done better there given how long it has been since I opened this |
|
PR #33399: Size comparison from 41b6830 to dc54e07 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
I still need to go back and do this. Coming soon! |
kiel-apple
force-pushed
the
darwin-cooking-appliances-introduction
branch
from
2bf2f41
to
cd2fc6b
Compare
|
need to move all these entries forward to new Future since Future from back when this started has been released |
|
PR #33399: Size comparison from 4efe777 to cd2fc6b Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -9689,13 +9685,144 @@ | |||
| watchOS: "11.2" | |||
| tvOS: "18.2" | |||
| introduced: | |||
| clusters: | |||
| - MicrowaveOvenControl | |||
| - MicrowaveOvenMode | |||
There was a problem hiding this comment.
So... now when I run codegen with this PR as of right now (rev cd2fc6b) I see a bunch of warnings about thigns that are not annotated as either provisional, removed, or introduced, right?
|
PR #33399: Size comparison from 4efe777 to 3bbc5b9 Full report (3 builds for cc32xx, stm32)
|
|
PR #33399: Size comparison from 4efe777 to 5a75b1e Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33399: Size comparison from 4efe777 to 4423fbe Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33399: Size comparison from 4efe777 to ca6de16 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
and codegen add Microwave + Oven attributes and codegen more Microwave + Oven attributes and codegen add Microwave + Oven commands and codegen add Microwave + Oven command fields and codegen add Microwave + Oven structs and codegen add Microwave + Oven struct fields and codegen add Microwave + Oven events/event fields and codegen add Microwave + Oven enums and codegen add Microwave + Oven enum values and codegen add Microwave + Oven bitmaps / bitmap values and codegen
is X conformance
kiel-apple
force-pushed
the
darwin-cooking-appliances-introduction
branch
from
ca6de16
to
6fbcb6f
Compare
|
PR #33399: Size comparison from 62a4a97 to 6fbcb6f Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the theme of v1.3 promotions. Added comments about
WATTSand affected provisional bits.