Skip to content

only trigger by container events #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

lalyos
Copy link

@lalyos lalyos commented Nov 24, 2019

Docker introduced new type of events, which are breaking dockerhook.
For example in case of an image type event (like pull) the inspec() function will fail, as it was meant to inspect containers.

2019/11/24 13:51:51 [HACK] msg: &docker.APIEvents{Action:"pull", Type:"image", Actor:docker.APIActor{ID:"alpine:3.7", Attributes:map[stri$
g]string{"name":"alpine"}}, Status:"pull", ID:"alpine:3.7", From:"", Time:1574599911, TimeNano:1574599911309698300} 
panic: runtime error: slice bounds out of range

goroutine 123 [running]:
main.trigger(0xc0000a6340, 0x1, 0x1, 0xc00044d348, 0x4, 0xc00044d360, 0xa, 0xc0005ce000)
        /Users/lalyos/go/src/github.com/progrium/dockerhook/dockerhook.go:79 +0x69e
created by main.main
        /Users/lalyos/go/src/github.com/progrium/dockerhook/dockerhook.go:133 +0x6c4

use DOCKER_EVENT_FILTER for filter by event type (container/image/network/volume ...) or "all" for no filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant