-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos & wording in README + fix of book compilation errors #208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dev99problems, thanks for contributing!
There is one small notice regarding contributors.txt
and in other files, I could suggest rewording "проект" into "проєкт"
I haven't the ability to approve PRs, only commenting =)
book/contributors.asc
Outdated
@@ -5,6 +5,6 @@ | |||
|
|||
[source,tabsize=8] | |||
---- | |||
include::contributors.txt[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generated on the go by Rakefile
, so there is no need for such changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for mentioning this!
I couldn't make bundle install
land all the deps normally on [email protected], for some reason there's a problem with
[email protected] gem on my MacOS setup, so I wasn't able to run bundle exec rake
normally.
Reverting this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted
Was thinking about |
426e0b0
to
c1b1f85
Compare
@hedrok якщо буде змога, могли б подивитись ці зміни? |
Дякую, залив. |
Description
This brings some typos adjustments and wording updates to
README.md
to make wording there a bit more formaland a bit less authorish.
Also fixes 2 books generation errors:
contributors.txt
file — original eng. book now is providing a link to it incontributors.asc
, instead or including it, but the fun part — I couldn't find thecontributors.txt
file itself in eng. repo either, so just switching fromincluding
tolink
worked pretty wellasciidoc
formatting issue inbook/06-github/3-maintaining.asc
section