Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos & wording in README + fix of book compilation errors #208

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

dev99problems
Copy link
Contributor

Description

This brings some typos adjustments and wording updates to README.md to make wording there a bit more formal
and a bit less authorish.

Also fixes 2 books generation errors:

  • including non-existing contributors.txt file — original eng. book now is providing a link to it in contributors.asc, instead or including it, but the fun part — I couldn't find the contributors.txt file itself in eng. repo either, so just switching from including to link worked pretty well
  • fixes the asciidoc formatting issue in book/06-github/3-maintaining.asc section

@dev99problems
Copy link
Contributor Author

@burlakvo , @hedrok folks, if you'll find time to go through and provide a feedback — I'd be thankful

Copy link
Contributor

@burlakvo burlakvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dev99problems, thanks for contributing!

There is one small notice regarding contributors.txt and in other files, I could suggest rewording "проект" into "проєкт"

I haven't the ability to approve PRs, only commenting =)

@@ -5,6 +5,6 @@

[source,tabsize=8]
----
include::contributors.txt[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generated on the go by Rakefile, so there is no need for such changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mentioning this!
I couldn't make bundle install land all the deps normally on [email protected], for some reason there's a problem with
[email protected] gem on my MacOS setup, so I wasn't able to run bundle exec rake normally.

Reverting this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted

@dev99problems
Copy link
Contributor Author

@dev99problems, thanks for contributing!

There is one small notice regarding contributors.txt and in other files, I could suggest rewording "проект" into "проєкт"

I haven't the ability to approve PRs, only commenting =)

Was thinking about проєкт as well, because seems like since 2019 it is the proper & official spelling.
Will update in README.md

@dev99problems
Copy link
Contributor Author

@hedrok якщо буде змога, могли б подивитись ці зміни?

@hedrok hedrok merged commit b70ae07 into progit:master Nov 18, 2024
1 check passed
@hedrok
Copy link
Member

hedrok commented Nov 18, 2024

Дякую, залив.

@dev99problems dev99problems deleted the minor_improvements branch November 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants