Skip to content

fix: skip 400 responses in getCoinpayGlobalWalletTokens to allow fall… #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emil07770 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: skip 400 responses in getCoinpayGlobalWalletTokens to allow fall… #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/coinpayportal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ export async function getCoinpayGlobalWalletTokens(
if (!response.ok) {
const text = await response.text().catch(() => "");
errors.push(`${url.pathname}: ${response.status}${text ? ` ${text.slice(0, 120)}` : ""}`);
if ([401, 403, 404].includes(response.status)) continue;
if ([400, 401, 403, 404].includes(response.status)) continue;
throw new Error(`CoinPay get-tokens failed: ${response.status}`);
Comment on lines +564 to 565
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 400 may also silence client-side misconfiguration on all three endpoints

HTTP 400 (Bad Request) typically signals a permanent client-side error — for example, a malformed business_id, an unsupported API version, or an invalid bearer token format. Because that root cause applies equally to all three URLs, adding 400 to the skip list can cause two extra round-trips before the function eventually throws via the !sawSuccessfulResponse path, with the diagnostic message buried in errors[0]. If CoinPay returns 400 specifically for endpoint-level reasons (e.g., /get-tokens requires a plan upgrade), the fallback is correct; but if it signals a request-level misconfiguration that affects all endpoints, the extra calls add latency without value. Consider whether a comment documenting the specific CoinPay behaviour that motivated this change would help future maintainers distinguish the two cases.

}

Expand Down