софт делиты #94
Open
софт делиты #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2025 22:02
Open
Zimovchik
reviewed
Jul 2, 2025
Comment on lines
-25
to
+24
| username: constr(strip_whitespace=True, to_upper=True, min_length=1) | ||
| surname: constr(strip_whitespace=True, to_upper=True, min_length=1) |
Member
There was a problem hiding this comment.
почему принял решение переименовать?
Member
|
почему падают тесты? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
Добавил софт делиты. Ориентировался на код в пр #87
Детали реализации
1.Изменил структуру модуля models, чтобы был похож на rating api и тд
2.Добавил в таблицу union_member поле is_deleted
3.Изменил поведение ручек file/send/, file/upload_file, update_file_options в соответствии с новой логикой базовой модели
4.Поменял название поля класс UserCreate с username на surname, так как возникали ошибки в тестах
5.Изменил тесты в соответствии с новой структурой классов
6.Добавил новые исключения PrintAPIError, ObjectNotFound, AlreadyExists
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?