Conversation
Commit 81f92f1 introduced a selective update mechanism to _accounts_save() to prevent overwrites when running multiple instances by only modifying the specific account being saved. There was one mistake: the logic for adding a new account was tied to the final iteration of a loop over existing accounts. When starting with an empty accounts file, the loop never executes though. We can call g_key_file_set_value() directly and don't need the loop because this function will only modify one entry or add it if it doesn't exist.
Member
Author
|
@sjaeckel I believe like this it should work as well? |
sjaeckel
approved these changes
Mar 9, 2026
Member
sjaeckel
left a comment
sjaeckel
left a comment
There was a problem hiding this comment.
Yep, that works. I tested it and it's fine now.
Thanks for the fix and sorry for breaking it 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 81f92f1 introduced a selective update mechanism to _accounts_save() to prevent overwrites when running multiple instances by only modifying the specific account being saved.
There was one mistake: the logic for adding a new
account was tied to the final iteration of a loop over existing accounts.
When starting with an empty accounts file, the
loop never executes though.
We can call g_key_file_set_value() directly and don't need the loop because this function will only modify one entry or add it if it doesn't exist.
I didn't test this PR.