-
-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: align architecture with unstorage pattern #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
productdevbook
wants to merge
8
commits into
main
Choose a base branch
from
refactor/unstorage-architecture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use external libraries as optional peer dependencies: - nodemailer for SMTP - resend for Resend - @aws-sdk/client-ses for AWS SES - ofetch for HTTP - Remove FeatureFlags from Provider interface (unstorage style) - Update all provider implementations to use external SDKs - Update tests to properly mock external libraries using vi.hoisted - Fix playground tsconfig to include src directory Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Refactor zeptomail provider to use official zeptomail SDK - Add zeptomail as optional peer dependency - Update GitHub Actions to latest versions: - actions/checkout v4 → v6 - actions/setup-node v4 → v6 - pnpm/action-setup v4 - autofix-ci/action v1 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
02a9d51 to
76d7d00
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove zeptomail from peerDependencies (now bundled via noExternal) - Update tsconfig paths to resolve zeptomail types from node_modules - Delete custom zeptomail.d.ts in favor of package types - Update gen-providers script to generate lint-compliant code Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FeatureFlagsfrom Provider interface for cleaner APIChanges
External Libraries as Peer Dependencies
nodemailerpnpm add nodemailerresendpnpm add resend@aws-sdk/client-sespnpm add @aws-sdk/client-sesofetchpnpm add ofetchArchitecture Alignment
Test Updates
vi.hoisted()FeatureFlagsrelated testsTest plan
🤖 Generated with Claude Code