Fix Maven Central deploy: attach sources/javadoc/signatures, trim reactor - #2
Merged
Conversation
…d modules Maven Central rejected the 3.0.1-pb.1 bundle: no sources jars, javadoc jars, or GPG signatures were attached. The Atlassian central-pom parent only wires those under its release profile (activated by `mvn release:perform`), so a plain `mvn clean deploy` produced none of them. Declare maven-source-plugin, maven-javadoc-plugin (doclint off), and maven-gpg-plugin (sign bound to verify) directly in the build so every deploy attaches all three. Also trim <modules> to core + spring-webmvc (the only modules pb-universe consumes), dropping pact/wiremock/restassured/mockmvc/ spring-web-client/ktor-client/examples from the public release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1. The first
mvn clean deployof3.0.1-pb.1was rejected by the Central Portal because no artifacts had sources jars, javadoc jars, or GPG signatures attached — the Atlassiancentral-pomparent only wires those under a release profile (activated bymvn release:perform), which a plainmvn clean deploydoesn't trigger.maven-source-plugin,maven-javadoc-plugin(doclint off so third-party javadoc can't fail the release), andmaven-gpg-plugin(signbound toverify) directly in the build, so every deploy attaches sources + javadoc +.ascsignatures.<modules>tocore+spring-webmvc(the only modules pb-universe consumes), dropping pact/wiremock/restassured/mockmvc/spring-web-client/ktor-client/examples from the public release.Verified locally:
mvn clean verifyproduces main +-sources+-javadocjars for both modules; reactor builds with the two modules only.