Fix for Symbol#to_proc ArgumentError issue #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the long-standing issue where using Symbol#to_proc syntax (e.g., `field :name, &:first_name`) would raise an ArgumentError. **Problem:** BlockExtractor was calling all blocks with 2 arguments: `block.call(object, local_options)`. Symbol#to_proc forwards ALL arguments to the target method, causing it to call `object.method_name(local_options)`, which fails when methods don't accept extra arguments. **Solution:** Detect Symbol#to_proc by its characteristic parameter signature `[[:req], [:rest]]` and call it with only the object argument, while regular blocks continue to receive both arguments. **Benefits:** - Enables cleaner, more idiomatic Ruby syntax - Eliminates need for rubocop disable comments - Maintains full backward compatibility with existing code - No breaking changes to API Related: rubocop/rubocop#8201 Signed-off-by: Tobias Carvan <[email protected]>
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the long-standing issue where using Symbol#to_proc syntax (e.g.,
field :name, &:first_name) would raise an ArgumentError.Problem:
BlockExtractor was calling all blocks with 2 arguments:
block.call(object, local_options). Symbol#to_proc forwards ALL arguments to the target method, causing it to callobject.method_name(local_options), which fails when methods don't accept extra arguments.Solution:
Detect Symbol#to_proc by its characteristic parameter signature
[[:req], [:rest]]and call it with only the object argument, while regular blocks continue to receive both arguments.Benefits:
Related: rubocop/rubocop#8201
Checklist: