You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for landing this in contributor_docs/web_accessibility.md — that is the right file for #9105, and both requested bullets are present.
One accuracy gap vs current main (describe.js still describe(text, display) / describeElement(name, text, display); _describeHTML does not set lang):
The VoiceOver bullet talks about the HTML lang attribute as if describe() / describeElement() already emit it. They do not, until the optional lang work in #9100. #9105 is intentionally docs-ahead of that API, but the new section should say so in one clause so contributors do not think the attribute is already on the fallback/label nodes.
Suggested tightening (wording only; no API change):
Native script: prefer “write descriptions in the language’s native script (for example Devanagari for Hindi), not a Latin transliteration.” “Native script language” is easy to misread as “whatever language the author speaks.”
No need to tick the inline-reference / unit-test boxes for this contributor-doc change, and please do not add JSDoc lang syntax until #9100 actually lands the parameter.
Branch is behind main (mergeable_state: behind); the +7-line append should rebase cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9105
Changes:
describe()&describeElement()incontributor_docs/web_accessibility.mdlangattribute for Latin Script langsScreenshots of the change:
NA
PR Checklist
npm run lintpasses