Fix saveTable() not escaping double quotes in CSV output#8637
Open
avinxshKD wants to merge 1 commit intoprocessing:mainfrom
Open
Fix saveTable() not escaping double quotes in CSV output#8637avinxshKD wants to merge 1 commit intoprocessing:mainfrom
avinxshKD wants to merge 1 commit intoprocessing:mainfrom
Conversation
Contributor
Author
|
Hey @davepagurek @ksen0 pls take a look, added csvEscape() beside the existing escapeHelper, doubles inner quotes and triggers quoting on " and \n, not just ,. Headers get the same treatment now too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8551
Changes:
saveTable()only quoted CSV fields containing commas, but never escaped"inside them, producing malformed output. AddedcsvEscape()next to the existingescapeHelper, which doubles inner quotes and triggers quoting on"and\ntoo, not just,. Also fixes headers, which were never quoted at all. Updated the CSV download test to assert against the actual expected RFC 4180 output instead of rebuilding the same broken string.