Fix Color.toString() hex format support #8453
Open
+35
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Anshumancanrock
force-pushed
the
Color.toString
branch
from
2322bda to
8f8d94a
Compare
Anshumancanrock
changed the title
Anshumancanrock
force-pushed
the
Color.toString
branch
from
8f8d94a to
6a42c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8451
Changes:
Fixes
toString()not recognizing p5.js hex format strings in 2.0.The problem is that colorjs.io doesn't recognize p5.js format strings like
'#rrggbb','#rgb', etc. So I added a simple mapping layer that translates these to colorjs.io's'hex'format before passing them through.Now these all work:
toString('#rrggbb')toString('#rgb')toString('#rrggbbaa')toString('#rgba')toString('hex')(added as alias)Added tests for these cases too.
PR Checklist
npm run lintpasses