add unit tests for HSB color space #8376
Conversation
|
@davepagurek please take look |
|
Hey @limzykenneth, being more familiar with the HSB converters, how does this look to you? |
limzykenneth
left a comment
limzykenneth
left a comment
There was a problem hiding this comment.
One inline thing but the rest are good. Thanks.
test/unit/color/hsb.js
Outdated
| // Helper function to compare arrays with tolerance | ||
| const arrayApproximately = (arr1, arr2, delta = 0.01) => { | ||
| if (arr1.length !== arr2.length) return false; | ||
| for (let i = 0; i < arr1.length; i++) { | ||
| if (Math.abs(arr1[i] - arr2[i]) > delta) return false; | ||
| } | ||
| return true; | ||
| }; |
There was a problem hiding this comment.
This part is not being used and is not defined in the right way for an assertion. If you'd want to continue exploring this you can follow the implementation here: https://github.com/processing/p5.js/blob/dev-2.0/test/js/chai_helpers.js#L7-L12.
There was a problem hiding this comment.
I'm not sure that it should be directly attached to assert like this, especially in this file. Also it is still not being used, if it is not to be used then it don't really need to be there.
Piyushrathoree
force-pushed
the
add-hsb-tests
branch
from
f4091e9 to
ec34176
Compare
|
@limzykenneth removed that . check the tests as well. |
3 participants
Resolves #8375
Changes: added unit test for src/color/color_spaces/hsb.js
PR Checklist
npm run lintpasses