Bugfix: Prevent genType from being inferred as int in GLSL wrappers #7942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7900
Changes:
GLSL genType Inference Fix:
ShaderGenerator.js
where functions likesin()
were incorrectly inferringgenType
asint
when passed float literals (e.g.,sin(0.5)
).FunctionCallNode
'sdetermineFunctionSignature()
to:int
tofloat
when the expected argument type isgenType
.float
,vec2
,vec3
,vec4
) are allowed.Unit Test Fix:
test/unit/io/loadTable.js
to normalize line endings when asserting CSV content:\r\n
vs\n
newline inconsistencies.Screenshots of the change:
A purple box rendered using


sin(0.5)
in the fragment shader confirms correct float type inference.PR Checklist
npm run lint
passes