Fix duplicate p5.js init by checking window.p5 and skipping if alread… #7791
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limzykenneth
requested changes
May 14, 2025
Comment on lines
+128
to
+131
| if (window.p5 instanceof p5) { | ||
| console.warn('p5.js appears to have been imported multiple times. This could cause errors.'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
window.p5 is the constructor so it won't be an instance of p5, this condition will always be false.
| this._isGlobal = true; | ||
| window.p5 = this; |
There was a problem hiding this comment.
Overwriting window.p5 here will break a lot of things, it shouldn't be redefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y loaded
Resolves #7687
Changes:
window.p5 instanceof p5before global bindingObject.definePropertyredefinitionScreenshots of the change:
PR Checklist
npm run lintpasses