Fix: Added checks before removing event listeners#7705
Open
Sanketjadhav31 wants to merge 2 commits intoprocessing:mainfrom
Open
Fix: Added checks before removing event listeners#7705Sanketjadhav31 wants to merge 2 commits intoprocessing:mainfrom
Sanketjadhav31 wants to merge 2 commits intoprocessing:mainfrom
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
Author
|
Hi , |
Member
|
Hi @Sanketjadhav31 can you explain how this PR relates to the original issue? Also, the original issue looks closed? Regarding this PR: in which situation are those properties missing, that requires this checks? Additionally, rather than silently suppressing the error, could you log a more descriptive message? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #618
Changes:
removeEventListeneris only called when the target element and handler exist.removeEventListeneronundefinedvalues in themain.jsfile.Screenshots of the change:
Not applicable
PR Checklist
npm run lintpasses