fix: setFrame() under WebGL environment renders the correct frame#7611
Open
swastikCommits wants to merge 1 commit intoprocessing:mainfrom
Open
fix: setFrame() under WebGL environment renders the correct frame#7611swastikCommits wants to merge 1 commit intoprocessing:mainfrom
swastikCommits wants to merge 1 commit intoprocessing:mainfrom
Conversation
Contributor
Author
|
@davepagurek have a look into it, I am open to make further changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7370
Changes:
The core issue was missing texture updates in WEBGL. By adding the _modified flag and ensuring getTexture() triggers updates, the fix ensures the GPU texture stays in sync with the GIF animation.
Screenshots of the change:
None
PR Checklist
npm run lintpasses