Skip to content

fix: prevent menu links from being focusable when menu is closed #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: prevent menu links from being focusable when menu is closed #986

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0327d9
fix: prevent menu links from being focusable when menu is closed
hxrshxz Oct 6, 2025
3eb4b39
fix: replace className with class
hxrshxz Oct 6, 2025
e1f9341
Merge branch 'main' into menu-list-visibility
hxrshxz Oct 13, 2025
2c75fd8
Merge branch 'main' into menu-list-visibility
hxrshxz Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/components/Nav/MainNavLinks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,21 +75,31 @@ export const MainNavLinks = ({
<ul>
{links.map((link) => (
<li key={link.label}>
<a href={link.url}>{link.label}</a>
<a href={link.url} tabIndex={isOpen ? 0 : -1}>
Copy link
Collaborator

@coseeian coseeian Nov 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: since <a> elements are naturally focusable, we only need tabIndex when hiding them. Consider using tabIndex={isOpen ? undefined : -1} instead of the ternary with 0, which avoids redundant attributes in DOM.

This would apply to all three link groups (nav links on L78, editor button on L89, and donate button on L101).

{link.label}
</a>
</li>
))}
</ul>
<ul class="flex flex-col gap-[15px]">
<li>
<a className={styles.buttonlink} href="https://editor.p5js.org">
<a
className={styles.buttonlink}
href="https://editor.p5js.org"
tabIndex={isOpen ? 0 : -1}
>
<div class="mr-xxs">
<Icon kind="code-brackets" />
</div>
{editorButtonLabel}
</a>
</li>
<li>
<a className={styles.buttonlink} href="/donate/">
<a
className={styles.buttonlink}
href="/donate/"
tabIndex={isOpen ? 0 : -1}
>
<div class="mr-xxs">
<Icon kind="heart" />
</div>
Expand Down