Skip to content

fix(ui): resolved active link underline issue#951

Closed
Mayank2142 wants to merge 2 commits intoprocessing:mainfrom
Mayank2142:main
Closed

fix(ui): resolved active link underline issue#951
Mayank2142 wants to merge 2 commits intoprocessing:mainfrom
Mayank2142:main

Conversation

@Mayank2142
Copy link
Copy Markdown

@Mayank2142 Mayank2142 commented Aug 30, 2025

Resolves #870

@yugalkaushik
Copy link
Copy Markdown

@Mayank2142 Can you share the screenshot of screen related to this fix & mention what exactly the issues was.

@Mayank2142
Copy link
Copy Markdown
Author

bfa71628-7ea2-49b4-8e79-de1c6bb5df1a e1e7a619-52b5-4436-8f40-49330c6b0ed3 issue:- [Link Item] Underline styling is applied to a non-link container instead of the link itself #870

@coseeian
Copy link
Copy Markdown
Collaborator

With the following SCSS settings, the .current styles are not being applied, even though the a element in the HTML does have the current class. In the browser’s styles panel, there is no trace of the .current class being applied, although it does exist in the compiled CSS file.
 
.linklabel {  a {    color: inherit;    text-decoration: none;    &.current {      text-decoration: underline;      text-decoration-thickness: 2px;      text-underline-offset: 2px;    }  }}

@ksen0 ksen0 requested review from coseeian and removed request for coseeian September 18, 2025 09:11
@ksen0
Copy link
Copy Markdown
Member

ksen0 commented Sep 18, 2025

Hi @Mayank2142 , thanks for working on this! Just a quick note that I've added a "Resolves issue" comment to your PR - this way it can be linked to the original issue. Also @coseeian have left some comments above, please follow up and update your PR or ask for any help if needed!

@coseeian
Copy link
Copy Markdown
Collaborator

Hi @Mayank2142 ,

Just checking in to see how you're doing with this PR, as it's been a while. I've left a few comments on the PR previously, and I'd welcome any discussion or thoughts you have on those!

Also, please let me know if you're still planning to continue - a quick confirmation within the next 7 days would be great. That's not a deadline to finish the task, just a ping to confirm you are still working on it. If not, no problem at all - the issue can be opened back up for other volunteers if I don't hear back from you by next week.

Thank you!

@Mayank2142
Copy link
Copy Markdown
Author

Mayank2142 commented Jan 23, 2026

Hi @coseeian ,
Thank you so much for giving me the opportunity to work on this PR. I really appreciate your time, guidance, and the comments you shared.
I’m sorry that I wasn’t able to complete the task within the expected time. I did try my best, but unfortunately I couldn’t make enough progress to deliver it properly. Because of that, I think it would be better to pass this opportunity to the next contributor who can take it forward more effectively.
Thank you again for the chance to learn from this, and I hope to contribute again in the future.
Best regards,
@Mayank2142

@coseeian
Copy link
Copy Markdown
Collaborator

Hi @Mayank2142 , thank you for the timely response, and no worries. :)

@ksen0
Copy link
Copy Markdown
Member

ksen0 commented Feb 3, 2026

Thanks both, @Mayank2142 and @coseeian ! I appreciate both your work on this. I'll close the PR.

@ksen0 ksen0 closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Link Item] Underline styling is applied to a non-link container instead of the link itself

4 participants