-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix: Prevent duplicate file renaming in sidebar #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…js-web-editor into Branch_Kamakshi
@raclim Currently, if a user tries to rename a file to a name that already exists in the same directory, the name simply reverts to the original without any visual feedback. No error message or dialog is shown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding these issues and suggesting these fixes for them! I really like the renaming on double-click implementation!
In terms of giving some sort of visual feedback or warning—I think maybe we can try what you currently have here for now and see how folks respond. Thanks so much again for your work on this!
Fixes #3454 and #3456
Changes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123