Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Add workflows for accessibility #852

Closed
wants to merge 17 commits into from
Closed

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Feb 9, 2023

No description provided.

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) poc 💫 Experimentation to discuss about future implementation. Not intended to be merged labels Feb 9, 2023
@csouchet csouchet force-pushed the accessibility_auto_tests branch 2 times, most recently from 15b0305 to 6d78989 Compare February 9, 2023 10:05
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

♻️ PR Preview c779d11 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet
Copy link
Member Author

csouchet commented Feb 9, 2023

.flDDCN.Link__LinkInButton-sc-1epbwti-1.jeiKGq

image

The Demo button failed.

image

# Using the Lighthouse GitHub Action
# @see https://github.com/marketplace/actions/lighthouse-ci-action
- name: Run Lighthouse GitHub Action
uses: treosh/lighthouse-ci-action@v9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ could we also check https://github.com/foo-software/lighthouse-check-action which seems to offer more options? in another workflow for example.

src/components/seo.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@process-analytics-bot process-analytics-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://process-analytics-process-analytics-dev-site_preview-pr-852.surge.sh/

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link
Contributor

@process-analytics-bot process-analytics-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://process-analytics-process-analytics-dev-site_preview-pr-852.surge.sh/

Device URL
mobile https://process-analytics-process-analytics-dev-site_preview-pr-852.surge.sh/

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@csouchet
Copy link
Member Author

csouchet commented Feb 9, 2023

Result

Never returns any errors :

  • ♿️ A11Y CI with a11ytester-action / a11ytester-action-CLI
  • ♿️ A11Y CI with a11ywatch / a11ywatch-CLI (pull_request)

♿️ A11Y CI with Lighthouse Check: There is no information on what doesn't work well.

For the others, they are complementary. Sometimes, there are the same errors. Sometimes, there are different errors.

@csouchet csouchet force-pushed the accessibility_auto_tests branch 3 times, most recently from 6cbac67 to c4b4ed1 Compare February 20, 2023 16:25
@csouchet csouchet force-pushed the accessibility_auto_tests branch 2 times, most recently from 249601b to fbfe615 Compare August 1, 2023 11:35
@process-analytics-bot
Copy link
Contributor

♿️ Pa11y report

Audited website : https://process-analytics-process-analytics-dev-site_preview-pr-852.surge.sh/

Running Pa11y on 1 URLs:

 > https://process-analytics-process-analytics-dev-site_preview-pr-852.surge.sh/ - 21 errors

Errors in https://process-analytics-process-analytics-dev-site_preview-pr-852.surge.sh/:

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 4.92:1. Recommendation:  change background to #060606.

   (#gatsby-focus-wrapper > main > div > div > div > div > div:nth-child(3) > a)

   <a class="MuiTypography-root MuiTypography-inherit MuiLink-root
   MuiLink-underlineNone MuiButtonBase-root MuiButton-root MuiButton-contained
   MuiButton-containedSecondary MuiButton-sizeMedium
   MuiButton-containedSizeMedium MuiButton-root MuiButton-conta...

 • The heading structure is not logically nested. This h5 element should be an
   h3 to be properly nested.

   (#libraries > div > div > div > div:nth-child(1) > div > div > div >
   div:nth-child(1) > div > div:nth-child(1) > h5)

   <h5 class="MuiTypography-root MuiTypography-h5
   css-fk5k8x">bpmn-visualization</h5>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#libraries > div > div > div > div:nth-child(1) > div > div > div >
   div:nth-child(1) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline
   css-187pqnf">TypeScript</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#libraries > div > div > div > div:nth-child(2) > div > div > div >
   div:nth-child(1) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">R</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#libraries > div > div > div > div:nth-child(3) > div > div > div >
   div:nth-child(1) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline
   css-187pqnf">Experimental</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#libraries > div > div > div > div:nth-child(4) > div > div > div >
   div:nth-child(1) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline
   css-187pqnf">Javascript</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#news > div > div > div:nth-child(1) > div:nth-child(1) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">3 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#news > div > div > div:nth-child(1) > div:nth-child(2) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">3 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#news > div > div > div:nth-child(1) > div:nth-child(3) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">4 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#news > div > div > div:nth-child(1) > div:nth-child(4) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">2 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#news > div > div > div:nth-child(1) > div:nth-child(5) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">5 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#news > div > div > div:nth-child(1) > div:nth-child(6) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">4 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 4.92:1. Recommendation:  change background to #060606.

   (#news > div > div > div:nth-child(2) > a)

   <a class="MuiButtonBase-root MuiButton-root MuiButton-text
   MuiButton-textQuaternary MuiButton-sizeMedium MuiButton-textSizeMedium
   MuiButton-root MuiButton-text MuiButton-textQuaternary MuiButton-sizeMedium
   MuiButton-textSizeMedium css-jpjv08" tabinde...

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#blog > div > div > div:nth-child(1) > div:nth-child(1) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">8 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#blog > div > div > div:nth-child(1) > div:nth-child(2) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">8 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#blog > div > div > div:nth-child(1) > div:nth-child(3) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">6 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#blog > div > div > div:nth-child(1) > div:nth-child(4) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">3 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#blog > div > div > div:nth-child(1) > div:nth-child(5) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">12 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 1.84:1. Recommendation:  change text colour to #00664a.

   (#blog > div > div > div:nth-child(1) > div:nth-child(6) > div > div > a >
   div > div:nth-child(2) > div > div:nth-child(2) > span)

   <span class="MuiTypography-root MuiTypography-overline css-187pqnf">2 min
   read</span>

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 4.92:1. Recommendation:  change background to #060606.

   (#blog > div > div > div:nth-child(2) > a)

   <a class="MuiButtonBase-root MuiButton-root MuiButton-text
   MuiButton-textQuaternary MuiButton-sizeMedium MuiButton-textSizeMedium
   MuiButton-root MuiButton-text MuiButton-textQuaternary MuiButton-sizeMedium
   MuiButton-textSizeMedium css-jpjv08" tabinde...

 • This element has insufficient contrast at this conformance level. Expected a
   contrast ratio of at least 7:1, but text in this element has a contrast
   ratio of 4.92:1. Recommendation:  change background to #060606.

   (#gatsby-focus-wrapper > main > section:nth-child(8) > div > div > div >
   div:nth-child(1) > form > div > div:nth-child(2) > button)

   <button class="MuiButtonBase-root MuiButton-root MuiButton-contained
   MuiButton-containedSecondary MuiButton-sizeMedium
   MuiButton-containedSizeMedium MuiButton-root MuiButton-contained
   MuiButton-containedSecondary MuiButton-sizeMedium MuiButton-contai...

✘ 0/1 URLs passed

This report has been generated using pa11y-ci.

@process-analytics-bot
Copy link
Contributor

♿️ Axe report

Audited website : https://process-analytics-process-analytics-dev-site_preview-pr-852.surge.sh/

Running axe-core 4.8.2 in chrome-headless

Testing https://process-analytics-process-analytics-dev-site_preview-pr-852.surge.sh/ ... please wait, this may take a minute.
 0 violations found!
Testing complete of 1 pages

Please note that only 20% to 50% of all accessibility issues can automatically be detected. 
Manual testing is always required. For more information see:
https://dequeuniversity.com/curriculum/courses/testingmethods



This report has been generated using @axe-core/cli.

@process-analytics-bot
Copy link
Contributor

⚡️🏠 Lighthouse report

Audited website : https://process-analytics-process-analytics-dev-site_preview-pr-852.surge.sh/
Complete report is here. Here's the summary:

Category Score
🔴 Performance 48
🟢 Accessibility 99
🟠 Best practices 83
🟢 SEO 92
🟠 PWA 78
This report has been generated using lighthouse.

@csouchet
Copy link
Member Author

replaced by #1161, #1162, #1163, #1164, #1165, #1166

@csouchet csouchet closed this Sep 22, 2023
@csouchet csouchet deleted the accessibility_auto_tests branch September 22, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) poc 💫 Experimentation to discuss about future implementation. Not intended to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants