Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme): remove the unnecessary ThemeProvider on the Header component #1040

Merged

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Jul 7, 2023

Based on our team's decision, we no longer require approval of the refactoring pull request. Instead, we will review and approve the refactoring once all changes related to a specific component have been completed.

@csouchet csouchet added the refactoring Code refactoring label Jul 7, 2023
@csouchet
Copy link
Member Author

csouchet commented Jul 7, 2023

The navbar appears like before 😊  

@csouchet csouchet merged commit 9d27f43 into main Jul 7, 2023
5 checks passed
@csouchet csouchet deleted the remove_unnecesary_theme_provider_on_header_component branch July 7, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant