-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganization #249
Reorganization #249
Conversation
Fixed some small bugs
Thanks a lot @CalebQ42. As a general rule, I'd like to avoid configurability in appimaged when possible; ideally it should "just work" for everyone in the same way. But since so many people have reported issues with the current state of MQTT (and it is experiemental, as is the rest of the tools) I think we should disable it for now by default and only use it if explicitl requested by the user. |
I think having a couple options that don't change the actual functionality could be useful. In particular, in #178 it's mentioned that disabling desktop notifications would be very nice to have. In that issue it was mentioned to check for the existence of a file ( For the MQTT update service, I agree that it would probably be best to default it to disabled until it get some work, but it's probably best to keep it available to allow for easier testing. In these cases, would you prefer to pass-through the flags used when installing the service or simply leave it and if someone really wants to use the flags then they'll have to manually edit the service file themselves? |
This is mostly some re-organization and cleanup loosely similar to #234
And a couple features for appimaged: