The forward kernel #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MET-36 Integrate and test the forward pass
Definition of done:
|
horizon-blue
force-pushed
the
xiaoyan/forward
branch
2 times, most recently
from
7669863 to
c01045a
Compare
Fix link issue & create binding for forward function
horizon-blue
force-pushed
the
xiaoyan/forward
branch
from
c01045a to
73fb4b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MET-36
Summary of Changes
Things can run without crash now (see
test_forward.pyfor examples on how to call therender_fmbsfunction and get back an image on Python side), but I haven't verified correctness yet. I'm going to publish this PR before it's fully ready yet in case we want to refer to it while working on other parts in parallelTest Plan
pixi run test