Refactor to use Vec3D instead of Ray
#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MET-36 Integrate and test the forward pass
Definition of done:
|
Contributor
Author
|
I'm merging this because no one has time to do PR review during final period :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of MET-36
Summary of Changes
Replace all instances of the
Rayclass withVec3D(primarily in intersector and getter) to streamline the code and remove unused components.This is part of my sequence of PRs for the forward kernels. The hope is to keep each of them small so that even if we are not going to review it now, it will be easier to catch up after the final deadline and understand what changes were maded.
Test Plan
pixi run test