📦 ci(.github): added checkout action to the release please action

prjctimg · Apr 7, 2024 · fc8ffbf · fc8ffbf
1 parent d270d7f
commit fc8ffbf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/.github/workflows/deploy-docs.yml b/.github/workflows/deploy-docs.yml
@@ -27,10 +27,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: build site
+      - name: Build site
         uses: JamesIves/github-pages-deploy-action@v4
         with:
-          # Upload entire repository
+          # Upload directory with assets
           folder: ./docs/www
           branch: gh-pages
           clean-exclude: pr-preview

diff --git a/.github/workflows/preview-docs.yml b/.github/workflows/preview-docs.yml
@@ -1,8 +1,8 @@
-name: Deploy GitHub PAges Preview
+name: Deploy GitHub Pages Preview
 on:
   push:
     branches:
-      - main
+      - dev
   pull_request:
     types:
       - opened
@@ -15,7 +15,7 @@ jobs:
   deploy-preview: 
    runs-on: ubuntu-latest
    steps:
-     - uses: actions/checkout@v3
+     - uses: actions/checkout@v4
      - name: Install and Build
        if: github.event.action  != 'closed' # skips build step if pr is closed 
 
@@ -27,7 +27,7 @@ jobs:
        uses: rossjrw/[email protected]
        with:
          token: ${{secrets.GH_PAT}}
-         preview-branch: main
+         preview-branch: ${{ github.ref }}
          source-dir: ./docs/www
          umbrella-dir: ./docs/pr-preview
          action: auto
diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml
@@ -14,22 +14,23 @@ jobs:
   release-please:
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/checkout@v4
       - uses: google-github-actions/release-please-action@v4
         id: release
         with:
           release-type: node
           target-branch: ${github.ref_name}}
           token: ${{secrets.GH_PAT}}
+          if: ${{ steps.release.outputs.release_created }}
       # The logic below handles the npm publication:
-      - uses: actions/checkout@v4
+      - name: Publish to NPM
         # these if statements ensure that a publication only occurs when
         # a new release is created:
         if: ${{ steps.release.outputs.release_created }}
       - uses: actions/setup-node@v4
         with:
           node-version: 20
           registry-url: 'https://registry.npmjs.org'
-        if: ${{ steps.release.outputs.release_created }}
       - run: |
           npm install
           npm test
@@ -38,3 +39,4 @@ jobs:
         env:
           NODE_AUTH_TOKEN: ${{secrets.NPM_PUBLISH}}
         if: ${{ steps.release.outputs.release_created }}
+