fix: pass custom tsconfig to rollup-plugin-dts #90
Conversation
|
Thanks for the PR!
Would you mind adding a test for this? Would like to have the motivating use-case codified so it doesn't get removed or break in the future. |
Added our test case to the PR ✔️ |
tests/specs/builds/typescript.ts
Outdated
| }); | ||
|
|
||
| expect(pkgrollProcess.exitCode).toBe(0); | ||
| expect(pkgrollProcess.stderr).toBe(''); |
There was a problem hiding this comment.
There doesn't seem to be anything here asserting that the correct tsconfig was passed in
privatenumber
force-pushed
the
master
branch
from
224476e to
9f1195f
Compare
|
My bad, I accidentally closed this trying to push my commit and I'm unable to re-open it. There were some errors I had to work around since your branch name is identical to the repo's default branch. Moved to #102 |
Hey! First time contributing here 🚀
It's a small fix to pass the custom tsconfig to rollup-plugin-dts, we had issues on our monorepo using custom tsconfigs to disable incremental builds and rollup-plugin-dts kept complaining because it's using the default "tsconfig.json" that it finds.
Found the same issue on tsup and they fixed this a year ago.