Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle native node plugins #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roryabraham
Copy link

@roryabraham roryabraham commented Jun 8, 2024

Hi 👋🏼

First PR in this repo so I'm open to feedback 🙂

This PR is pretty simple - it adds the https://github.com/danielgindi/rollup-plugin-natives rollup plugin to this repo, such that it can handle projects with dependencies that include native node modules as well as pure-JS modules.

An easy way to test this is using this branch in your npm link package.

Chokidar depends on a fsevents native node plugin. If you add it to your link package and use it, you'll get an error when pnpm prepack.

@roryabraham
Copy link
Author

I'll throw up some testing steps in a little bit, but spoiler alert I tested this with https://github.com/privatenumber/link when I was trying to add chokidar (which it sounds we might not want to do anyways 🙃)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant