Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏼
First PR in this repo so I'm open to feedback 🙂
This PR is pretty simple - it adds the https://github.com/danielgindi/rollup-plugin-natives rollup plugin to this repo, such that it can handle projects with dependencies that include native node modules as well as pure-JS modules.
An easy way to test this is using this branch in your npm
link
package.Chokidar depends on a
fsevents
native node plugin. If you add it to yourlink
package and use it, you'll get an error whenpnpm prepack
.