fix: import/require to respect export maps

src/utils/get-rollup-configs.ts

@@ -70,8 +70,6 @@ const getConfig = {
 				}),
 				nodeResolve({
 					extensions: ['.mjs', '.js', '.ts', '.jsx', '.tsx', '.json'],
-					// Order from https://nodejs.org/api/packages.html#conditional-exports
-					exportConditions: ['node', 'import', 'require', 'default'],
 				}),
 				...(
 					Object.keys(env).length > 0

tests/fixture-package/src/dependency-exports-import.js

@@ -0,0 +1,3 @@
+import esm from 'dependency-exports-dual';
+
+console.log(esm);

tests/fixture-package/src/dependency-exports-require.js

@@ -1,4 +1 @@
-import someValue from 'dependency-exports-require';
-
-console.log(someValue);
-
+console.log(require('dependency-exports-dual'));

tests/specs/builds/externalize-dependencies.ts → tests/specs/builds/dependencies.ts

@@ -25,7 +25,7 @@ export default testSuite(({ describe }, nodePath: string) => {
 			await fixture.cleanup();
 		});
 
-		test('dependency with exports.require', async () => {
+		test('dual package - require', async () => {
 			const fixture = await createFixture('./tests/fixture-package');
 
 			await fixture.writeJson('package.json', {
@@ -38,7 +38,25 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(pkgrollProcess.stderr).toBe('');
 
 			const content = await fixture.readFile('dist/dependency-exports-require.js', 'utf8');
-			expect(content).toMatch('1234');
+			expect(content).toMatch('cjs');
+
+			await fixture.cleanup();
+		});
+
+		test('dual package - import', async () => {
+			const fixture = await createFixture('./tests/fixture-package');
+
+			await fixture.writeJson('package.json', {
+				main: './dist/dependency-exports-import.js',
+			});
+
+			const pkgrollProcess = await pkgroll([], { cwd: fixture.path, nodePath });
+
+			expect(pkgrollProcess.exitCode).toBe(0);
+			expect(pkgrollProcess.stderr).toBe('');
+
+			const content = await fixture.readFile('dist/dependency-exports-import.js', 'utf8');
+			expect(content).toMatch('esm');
 
 			await fixture.cleanup();
 		});

tests/specs/builds/index.ts

@@ -8,7 +8,7 @@ import specTypes from './types';
 import specPackageExports from './package-exports';
 import specPackageImports from './package-imports';
 import specBin from './bin';
-import specExternalizeDependencies from './externalize-dependencies';
+import specDependencies from './dependencies';
 import specSrcDist from './src-dist';
 
 export default testSuite(({ describe }, nodePath: string) => {
@@ -22,7 +22,7 @@ export default testSuite(({ describe }, nodePath: string) => {
 		runTestSuite(specPackageExports, nodePath);
 		runTestSuite(specPackageImports, nodePath);
 		runTestSuite(specBin, nodePath);
-		runTestSuite(specExternalizeDependencies, nodePath);
+		runTestSuite(specDependencies, nodePath);
 		runTestSuite(specSrcDist, nodePath);
 	});
 });