Skip to content

Commit

Permalink
lintfix
Browse files Browse the repository at this point in the history
  • Loading branch information
privatenumber committed Mar 8, 2024
1 parent 0811646 commit 76700f0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/loader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ async function ESBuildLoader(
* Enable dynamic import by default to support code splitting in Webpack
*/
transformOptions.supported = {
"dynamic-import": true,
...(transformOptions.supported ?? {})
'dynamic-import': true,
...transformOptions.supported,
};

try {
Expand Down
13 changes: 9 additions & 4 deletions tests/specs/loader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ export default testSuite(({ describe }, webpack: typeof webpack4 | typeof webpac
'/src/test2.js': 'export default "test2"',
},
(config) => {
configureEsbuildLoader(config, { options: { target: "chrome52" } });
configureEsbuildLoader(config, { options: { target: 'chrome52' } });
},
webpack,
);
Expand All @@ -427,7 +427,7 @@ export default testSuite(({ describe }, webpack: typeof webpack4 | typeof webpac
expect(assets).toHaveProperty(['index.js']);
expect(Object.keys(assets).length).toBe(2);

expect(await built.require('/dist')()).toBe("test2");
expect(await built.require('/dist')()).toBe('test2');
});

test('Dynamic imports can be disabled', async () => {
Expand All @@ -437,7 +437,12 @@ export default testSuite(({ describe }, webpack: typeof webpack4 | typeof webpac
'/src/test2.js': 'export default "test2"',
},
(config) => {
configureEsbuildLoader(config, { options: { target: "chrome52", supported: { "dynamic-import": false } } });
configureEsbuildLoader(config, {
options: {
target: 'chrome52',
supported: { 'dynamic-import': false },
},
});
},
webpack,
);
Expand All @@ -449,7 +454,7 @@ export default testSuite(({ describe }, webpack: typeof webpack4 | typeof webpac
expect(assets).toHaveProperty(['index.js']);
expect(Object.keys(assets).length).toBe(1);

expect(await built.require('/dist')()).toBe("test2");
expect(await built.require('/dist')()).toBe('test2');
});
});
});

0 comments on commit 76700f0

Please sign in to comment.