Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add ESM and debug mode #162

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

nicolasiscoding
Copy link
Contributor

No description provided.

@zedtux
Copy link
Contributor

zedtux commented Nov 16, 2022

I just gave a try to your branch but I have the following error from the webpack output :

Module not found: Error: Can't resolve 'html-to-docx' in ...
resolve 'html-to-docx' in ...
  Parsed request is a module
  ...

I have installed your fork using yarn add https://github.com/nicolasiscoding/html-to-docx.git\#feature/debugmode and then restarted webpack.

Here is how I import it :

import HTMLtoDOCX from 'html-to-docx'

After other tries I realised that using yarn add <git URL> doesn't bring all the files, and therefore couldn't work, don't know why, so the above error shouldn't be related to your work.

@nicolasiscoding
Copy link
Contributor Author

@zedtux were you able to figure it out?

@zedtux
Copy link
Contributor

zedtux commented Feb 5, 2023

Well, yes, as I said, the yarn add command didn't come with all the files, I don't know why.

All in all, I'm ending up using the patch-package package to patch this lib. I can't help you more, I'm afraid, sorry.

@milahu milahu mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants