Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve helper logs on bounce #87

Merged
merged 3 commits into from
Sep 26, 2024
Merged

preserve helper logs on bounce #87

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8963aa4
preserve helper logs on bounce
eriktaubeneck Sep 25, 2024
3e7f011
add = to nextjs version
eriktaubeneck Sep 25, 2024
ef519b6
pylint error name change
eriktaubeneck Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion etc/start_helper_sidecar.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ helper_port=$5
sidecar_port=$6
identity=$7

nohup draft run-helper-sidecar --config_path "$config_path" --root_path "$root_path" --helper_domain "$helper_domain" --sidecar_domain "$sidecar_domain" --helper_port "$helper_port" --sidecar_port "$sidecar_port" --identity "$identity" > .draft/logs/helper_sidecar.log 2>&1 & echo $! > $pid_file
log_file=".draft/logs/helper_sidecar_$(date "+%Y-%m-%d_%H-%M-%S").log"
nohup draft run-helper-sidecar --config_path "$config_path" --root_path "$root_path" --helper_domain "$helper_domain" --sidecar_domain "$sidecar_domain" --helper_port "$helper_port" --sidecar_port "$sidecar_port" --identity "$identity" > "$log_file" 2>&1 & echo $! > $pid_file
2 changes: 1 addition & 1 deletion server/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"chartjs-adapter-spacetime": "^1.0.1",
"clsx": "^2.0.0",
"haikunator": "^2.1.2",
"next": "14.2.11",
"next": "=14.2.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider the trade-offs of exact version pinning

The change from "next": "^14.2.11" to "next": "=14.2.11" locks the Next.js version to exactly 14.2.11. While this ensures consistency across environments, it may prevent automatic security updates and bug fixes.

Consider these alternatives:

  1. Use a tilde (~) instead of an equals sign to allow patch updates: "next": "~14.2.11"
  2. Keep the caret (^) to allow minor updates, but use a package lock file to ensure consistency.
  3. If exact pinning is necessary, implement a process to regularly check for and manually update to new versions.

Could you explain the reasoning behind this exact version pinning? If it's to address a specific issue, consider documenting it in a comment.

"octokit": "^3.1.2",
"pm2": "^5.4.1",
"react": "^18",
Expand Down
Loading