Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update start query command in line with changes to IPA #80

Merged
merged 1 commit into from
Sep 17, 2024
Merged

update start query command in line with changes to IPA #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sidecar/app/query/ipa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ def build_from_query(cls, query: IPACoordinatorQuery):
def build_command(self) -> LoggerOutputCommand:
return LoggerOutputCommand(
cmd=f"{self.report_collector_binary_path} --network {self.network_config} "
f"--input-file {self.test_data_path} oprf-ipa "
f"--input-file {self.test_data_path} semi-honest-oprf-ipa-test "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

Input file 'semi-honest-oprf-ipa-test' not found in the repository

The change in sidecar/app/query/ipa.py references an input file semi-honest-oprf-ipa-test, but this file does not exist in the repository. This discrepancy may lead to runtime errors when attempting to use the non-existent file.

Action items:

  • Review the change and verify the correct input file name.
  • If the file should exist, ensure it's added to the appropriate location in the repository.
  • If the file name is incorrect, update the code to use the correct input file name.
Analysis chain

LGTM!

The change to the input file argument aligns with the PR objective of updating the start query command to be in line with changes to IPA.

To ensure the correctness of this change, please verify the following:

  1. The new input file semi-honest-oprf-ipa-test exists in the expected location.
  2. The contents of semi-honest-oprf-ipa-test are valid and appropriate for the updated testing scenario or operational mode related to the semi-honest OPRF protocol in IPA.

You can use the following script to verify the existence of the input file:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the new input file.

# Test: Check if the file exists. Expect: File exists.
if [ -f "semi-honest-oprf-ipa-test" ]; then
  echo "Input file 'semi-honest-oprf-ipa-test' exists."
else
  echo "Input file 'semi-honest-oprf-ipa-test' does not exist."
fi

Length of output: 163

Script:

#!/bin/bash
# Description: Search for files with names similar to 'semi-honest-oprf-ipa-test' across the repository

# Search for files containing 'oprf' and 'ipa' in their names (case-insensitive)
echo "Searching for files with names containing 'oprf' and 'ipa':"
fd -i -t f 'oprf.*ipa|ipa.*oprf'

# If no files are found, search for files containing either 'oprf' or 'ipa'
if [ $? -ne 0 ]; then
  echo "No files found with both 'oprf' and 'ipa'. Searching for files with either 'oprf' or 'ipa':"
  fd -i -t f 'oprf|ipa'
fi

Length of output: 193

Script:

#!/bin/bash
# Description: Search for files related to 'semi-honest-oprf-ipa-test' and display results

echo "Searching for files containing 'oprf' and 'ipa':"
fd -i -t f 'oprf.*ipa|ipa.*oprf' --exec echo {}

echo -e "\nSearching for files containing 'semi-honest':"
fd -i -t f 'semi-honest' --exec echo {}

echo -e "\nSearching for files containing either 'oprf' or 'ipa':"
fd -i -t f 'oprf|ipa' --exec echo {}

Length of output: 530

f"--max-breakdown-key {self.max_breakdown_key} "
f"--per-user-credit-cap {self.per_user_credit_cap} --plaintext-match-keys ",
logger=self.logger,
Expand Down
Loading