Local dev bugs

[eriktaubeneck]

Summary by CodeRabbit

• New Features

  • Introduced a new "Gate Type" selection menu with options.
  • Added UI and state management for stall detection in the query creation page.

• Enhancements

  • Improved signal handling to check for process existence before termination.
  • Updated default and dynamic path settings for local development in the CLI tool.

• Bug Fixes

  • Enhanced the start_ipa_helper function to include new parameters for gate type and stall detection, ensuring better integration and functionality.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
draft	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 7:19pm

[coderabbitai]

Walkthrough

This update introduces significant enhancements to the handling of UI elements and backend processes. The UI now includes a switch for stall detection and a new select menu for gate types. Backend improvements include enhanced signal handling, new attributes for gate type and stall detection in queries, and adjustments to the command execution and route handling mechanisms for better process management and flexibility.

Changes

Files/Paths	Change Summary
server/app/query/create/page.tsx	Added Switch import, new state for stall detection, updated UI elements, and introduced a select menu for gate types.
sidecar/app/command.py	Enhanced signal_handler to check for process existence before termination.
sidecar/app/query/ipa.py	Added GateType enum, and new attributes for gate type and stall detection in queries and build commands.
sidecar/app/routes/start.py	Introduced gate_type and stall_detection parameters in start_ipa_helper function.
sidecar/cli/cli.py	Updated default root_path handling in run_helper_sidecar and run_local_dev functions.

In code we trust, with changes we grow,
New gates to open, new paths to show.
A switch for detection, in UI we delight,
Backend enhanced, processes in sight.
From signals to queries, all polished and bright,
Together we code, from morning till night.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3d3b5f7 and 1abf6fb.

Files selected for processing (5)

• server/app/query/create/page.tsx (7 hunks)
• sidecar/app/command.py (1 hunks)
• sidecar/app/query/ipa.py (4 hunks)
• sidecar/app/routes/start.py (3 hunks)
• sidecar/cli/cli.py (2 hunks)

Additional comments not posted (12)

sidecar/app/command.py (1)

85-89: Robust signal handling with process existence check.

sidecar/app/routes/start.py (2)

42-43: New parameters gate_type and stall_detection added to start_ipa_helper.

---

58-59: Instantiation of IPAHelperQuery with new parameters.

sidecar/cli/cli.py (2)

162-162: Default value of root_path set to None in run_helper_sidecar.

---

268-268: Appending /tmp/sidecar/{role.value} to root_path in run_local_dev.

sidecar/app/query/ipa.py (5)

21-23: Addition of GateType enum with COMPACT and DESCRIPTIVE values.

---

164-165: New attributes gate_type and stall_detection added to IPAHelperCompileStep.

---

170-174: Instantiation of IPAHelperCompileStep with new attributes.

---

186-187: Usage of gate_type and stall_detection in build_command method.

---

399-400: New attributes gate_type and stall_detection added to IPAHelperQuery.

server/app/query/create/page.tsx (2)

329-347: Addition of Switch component for stall detection.

---

322-327: Addition of SelectMenu for selecting "Gate Type".