bugfixes for local dev setup (#23)

private-attribution · May 15, 2024 · 999341c · 999341c
1 parent 7547d6b
commit 999341c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/sidecar/app/command.py b/sidecar/app/command.py
@@ -82,10 +82,11 @@ def __enter__(self):
     def signal_handler(self, sig, _frame):
         print(f"Handling signal: {sig}")
         for process in self.processes:
-            for child in psutil.Process(process.pid).children(recursive=True):
-                child.terminate()
-                print(f"Terminating: {child}")
-            process.terminate()
+            if psutil.pid_exists(process.pid):
+                for child in psutil.Process(process.pid).children(recursive=True):
+                    child.terminate()
+                    print(f"Terminating: {child}")
+                process.terminate()
             print(f"Terminating: {process}")
         sys.exit(0)
 

diff --git a/sidecar/cli/cli.py b/sidecar/cli/cli.py
@@ -265,7 +265,7 @@ def run_local_dev(
             identity=role,
             helper_port=helper_ports[role],
             sidecar_port=sidecar_ports[role],
-            root_path=root_path,
+            root_path=root_path / Path(f"tmp/sidecar/{role.value}"),
             _env=_env,
         )
         for role in Role