Skip to content

Commit

Permalink
preserve helper logs on bounce (#87)
Browse files Browse the repository at this point in the history
* preserve helper logs on bounce

* add = to nextjs version

* pylint error name change
  • Loading branch information
eriktaubeneck authored Sep 26, 2024
1 parent 5182a31 commit 40e7c9b
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 7 deletions.
3 changes: 2 additions & 1 deletion etc/start_helper_sidecar.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ helper_port=$5
sidecar_port=$6
identity=$7

nohup draft run-helper-sidecar --config_path "$config_path" --root_path "$root_path" --helper_domain "$helper_domain" --sidecar_domain "$sidecar_domain" --helper_port "$helper_port" --sidecar_port "$sidecar_port" --identity "$identity" > .draft/logs/helper_sidecar.log 2>&1 & echo $! > $pid_file
log_file=".draft/logs/helper_sidecar_$(date "+%Y-%m-%d_%H-%M-%S").log"
nohup draft run-helper-sidecar --config_path "$config_path" --root_path "$root_path" --helper_domain "$helper_domain" --sidecar_domain "$sidecar_domain" --helper_port "$helper_port" --sidecar_port "$sidecar_port" --identity "$identity" > "$log_file" 2>&1 & echo $! > $pid_file
2 changes: 1 addition & 1 deletion server/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"chartjs-adapter-spacetime": "^1.0.1",
"clsx": "^2.0.0",
"haikunator": "^2.1.2",
"next": "14.2.11",
"next": "=14.2.11",
"octokit": "^3.1.2",
"pm2": "^5.4.1",
"react": "^18",
Expand Down
6 changes: 4 additions & 2 deletions sidecar/app/routes/start.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ def demo_logger(
return {"message": "Process started successfully", "query_id": query_id}


# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments
@router.post("/ipa-helper/{query_id}")
def start_ipa_helper(
query_id: str,
Expand All @@ -73,7 +75,6 @@ def start_ipa_helper(
background_tasks: BackgroundTasks,
request: Request,
):
# pylint: disable=too-many-arguments
query_manager = request.app.state.QUERY_MANAGER
check_capacity(query_manager)

Expand Down Expand Up @@ -153,6 +154,8 @@ def iterfile():
)


# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments
@router.post("/ipa-query/{query_id}")
def start_ipa_query(
query_id: str,
Expand All @@ -165,7 +168,6 @@ def start_ipa_query(
background_tasks: BackgroundTasks,
request: Request,
):
# pylint: disable=too-many-arguments
query_manager = request.app.state.QUERY_MANAGER
check_capacity(query_manager)

Expand Down
4 changes: 2 additions & 2 deletions sidecar/cli/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def start_traefik_local_command(
return Command(cmd=cmd, env=env)


# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments
@cli.command
@click.option(
"--config_path",
Expand Down Expand Up @@ -164,7 +164,7 @@ def run_helper_sidecar(
start_commands_parallel([sidecar_command, traefik_command])


# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments
@cli.command
@click.option(
"--config_path",
Expand Down

0 comments on commit 40e7c9b

Please sign in to comment.