Iterate on aggregator selection #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of `setlike` seems to be the right general approach for this, even if the spelling is a bit more verbose than is ideal. I've filled in more of the details of the protocol and improved some of the linking and references.
Comment on lines
+450
to
+458
| The <dfn enum>PrivateAttributionProtocol</dfn> describes the submission protocol | ||
| used by different [=aggregation services=]. This document defines two protocols: | ||
|
|
||
| <dl dfn-for=PrivateAttributionProtocol dfn-type=enum-value> | ||
| <dt><dfn>dap-11</dfn></dt> | ||
| <dd>A DAP-based protocol [[DAP]] that uses [=MPC=]; see [[#s-mpc]].</dd> | ||
| <dt><dfn>tee-00</dfn></dt> | ||
| <dd>A protocol for submission to a [=TEE=]; see [[#s-tee]].</dd> | ||
| </dl> |
There was a problem hiding this comment.
Maybe dap-11-histogram, with the possibility that we might add dap-11-sketch in the future? It seems like the report format is an additional variable beyond just the aggregation protocol. (Also see #10 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
setlikeseems to be the right general approach for this, even if the spelling is a bit more verbose than is ideal.I've filled in more of the details of the protocol and improved some of the linking and references.
With apologies to @bmcase, who will be affected in #29.