Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

fix(zk): use Aggregator in Threshold circuit #349

Merged
merged 13 commits into from
Sep 20, 2023

Conversation

duguorong009
Copy link
Contributor

@duguorong009 duguorong009 commented Sep 4, 2023

Description

  • Introduce the AggregatorChipset inside the ThresholdCircuit

Related issues

  • Close #318

Changes

  • Use the Aggregator in ThresholdCircuit, in order to validate the sets & scores
  • Update the unit test

@duguorong009 duguorong009 marked this pull request as draft September 4, 2023 14:28
@duguorong009
Copy link
Contributor Author

@lazovicff
Here, I am creating a PR with simple solution.
I think this simple solution is better fit for the original goal of the issue.

As we discussed in the meeting, I make this PR as draft one.
So, you can review the PR, and give the feedback.
Once we complete the Debug Aggregator issue, I will come back, merge the updates, and make the PR ready for review.

@duguorong009 duguorong009 marked this pull request as ready for review September 6, 2023 02:09
@ozgurarmanc ozgurarmanc force-pushed the threshold-circuit-use-aggregator-1 branch from 3a14a9d to 18cd104 Compare September 11, 2023 10:05
@lazovicff lazovicff force-pushed the threshold-circuit-use-aggregator-1 branch from 73b2329 to bff4a27 Compare September 18, 2023 17:47
@lazovicff lazovicff merged commit 5473dd1 into master Sep 20, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use aggregator inside Threshold Circuit
2 participants