This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
feat: native threshold circuit #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazovicff
reviewed
Sep 4, 2023
lazovicff
reviewed
Sep 4, 2023
brech1
force-pushed
the
feat/native-threshold-circuit
branch
from
a9f6b1c
to
1c7275c
Compare
|
Thanks for the review, I thought the threshold only applied to bandada groups, but after this review and today's meeting I understand it's part of the post processing. |
lazovicff
approved these changes
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims removes the comparison check for the bandada group score threshold from the
clicrate and implements theThresholdcircuit to verify the score value.Related Issues
Changes
num_rationaldependency to theeigentrustlib to create aBigRational.Thresholdcircuit to validate the score.