Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

feat: use native ECDSA implementation #346

Merged
merged 2 commits into from
Sep 5, 2023
Merged

feat: use native ECDSA implementation #346

merged 2 commits into from
Sep 5, 2023

Conversation

brech1
Copy link
Member

@brech1 brech1 commented Aug 25, 2023 •
edited
Loading

Description

This PR removes the external secp256k1 that was being used to generate the ECDSA key pairs and used for signing as well. It replaces it with the local native ECDSA implementation present in the eigentrust-zk crate.

Related Issues

  • #328

Changes

  • Add recovery_id getter for the ECDSA pair implementation.
  • Update tests.
  • Update conversions between attestation types in the attestation.rs module.
  • Move ECDSA related types to the eigentrust main lib.rs file.

@brech1 brech1 changed the title fix: ECDSA signature verification feat: use native ECDSA implementation Aug 31, 2023
@brech1 brech1 marked this pull request as ready for review September 5, 2023 01:32
@lazovicff lazovicff merged commit c826552 into master Sep 5, 2023
1 check passed
@brech1 brech1 deleted the fix/ecdsa-verify branch September 5, 2023 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lazovicff lazovicff lazovicff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brech1 @lazovicff