feat: integrate contract registries #370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ctrlc03
force-pushed
the
feat/registries
branch
from
a0137f9
to
70a9eb5
Compare
ctrlc03
force-pushed
the
feat/registries
branch
2 times, most recently
from
9bb935c
to
45c5ce0
Compare
ctrlc03
force-pushed
the
feat/registries
branch
2 times, most recently
from
9210c61
to
fd9de9a
Compare
ctrlc03
force-pushed
the
feat/registries
branch
from
fd9de9a
to
1b54632
Compare
ctrlc03
force-pushed
the
feat/registries
branch
from
1b54632
to
2c8b44b
Compare
ctrlc03
force-pushed
the
feat/registries
branch
from
2c8b44b
to
170a144
Compare
ctrlc03
force-pushed
the
feat/registries
branch
from
170a144
to
7d83d00
Compare
ctrlc03
force-pushed
the
feat/registries
branch
from
7d83d00
to
409b872
Compare
ctrlc03
force-pushed
the
feat/registries
branch
from
409b872
to
07576e6
Compare
ctrlc03
force-pushed
the
feat/registries
branch
from
07576e6
to
bba7671
Compare
ctrlc03
force-pushed
the
feat/registries
branch
from
bba7671
to
49d3b08
Compare
ctrlc03
force-pushed
the
feat/registries
branch
from
49d3b08
to
c3370a8
Compare
kittybest
reviewed
Oct 7, 2024
| @@ -29,7 +26,7 @@ import { getSemaphoreProof } from "~/utils/semaphore"; | |||
|
|
|||
| import type { IVoteArgs, MaciContextType, MaciProviderProps } from "./types"; | |||
| import type { PCD } from "@pcd/pcd-types"; | |||
| import type { EIP1193Provider } from "viem"; | |||
| import type { IPollData } from "~/utils/fetchPoll"; | |||
There was a problem hiding this comment.
I would suggest to put the IPollData to the ~/utils/types
| @@ -410,15 +408,14 @@ export const MaciProvider: React.FC<MaciProviderProps> = ({ children }: MaciProv | |||
|
|
|||
| /// check the poll data and tally data | |||
| useEffect(() => { | |||
| setIsLoading(true); | |||
|
|
|||
| // if we have the subgraph url then it means we can get the poll data through there | |||
| if (config.maciSubgraphUrl) { | |||
There was a problem hiding this comment.
check if the user provided the maci subgraph url here, do we need a callback reminding user to provide the url if they don't? (instead of fetching the contract data as a backup method, we just remind them to provide the url)
| isApproved?: boolean; | ||
| isLoading?: boolean; | ||
| } | ||
|
|
||
| export const ApplicationItem = ({ | ||
| id, | ||
| index, |
kittybest
reviewed
Oct 8, 2024
| deleteBallot: () => void; | ||
| ballotContains: (id: string) => Vote | undefined; | ||
| ballotContains: (index: number) => Vote | undefined; |
There was a problem hiding this comment.
ballotContains should also be receiving projectIndex? maybe we should name the arguments in consistency
| () => (rawReturn.data && rawReturn.data.length > 0) || (refetchedData && refetchedData.length > 0), | ||
| [rawReturn.data, refetchedData], | ||
| ); | ||
| // determine whether the project is approved ornot |
|
|
||
| <i className="text-sm">Applications can be edited and approved until the Application period ends.</i> | ||
| </p> | ||
| <i className="text-sm">Applications can be edited and approved until the Application period ends.</i> |
There was a problem hiding this comment.
we cannot edit now, right? thinking about remove the "edited" wording, add it back only after we have this function?
| * @param id - the application ID | ||
| * @returns the application | ||
| */ | ||
| export async function fetchApplicationById(registryAddress: string, id: string): Promise<IRequest> { |
There was a problem hiding this comment.
I don't quite understand the difference between fetchApplicationById and fetchApplicationByProjectId?(=> what's the difference between project id and application id?) for me to imagine the need of the organizer, should be
- fetch application by recipient address (since the payout page might need this, or in the future if we wanna build a page for the applicants to manage their uploaded application)
- fetch application by project id = application id (for display single application detail on the
/projects/:projectIdpage - fetch application by request id (? (maybe be used on the organizer managing applications page?)
| /** | ||
| * Whether it was approved or not | ||
| */ | ||
| initialized?: boolean; |
There was a problem hiding this comment.
just a question: why this is called initialized instead of something like isApproved?
1 task
…ter-registries fix: clear selected checkbox after approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate contract registries into the interface.
To fix:
To finish:
re #263