Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error handling(Error::Synthesis) #368

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

guorong009
Copy link

@guorong009 guorong009 commented Sep 19, 2024

Description

  • Improve the error handling related to Error::Synthesis

Related issues

Change

  • Add WitnessMissing variant to AssignError

@guorong009 guorong009 self-assigned this Sep 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 84.99%. Comparing base (81c7058) to head (3baa282).

Files with missing lines Patch % Lines
halo2_frontend/src/dev.rs 17.64% 14 Missing ⚠️
halo2_frontend/src/plonk/error.rs 0.00% 8 Missing ⚠️
halo2_frontend/src/plonk/keygen.rs 42.85% 8 Missing ⚠️
halo2_frontend/src/circuit.rs 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   85.07%   84.99%   -0.09%     
==========================================
  Files          85       85              
  Lines       18658    18684      +26     
==========================================
+ Hits        15874    15880       +6     
- Misses       2784     2804      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guorong009 guorong009 marked this pull request as ready for review September 26, 2024 07:07
Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guorong009 guorong009 merged commit 7c368af into main Sep 26, 2024
7 checks passed
@guorong009 guorong009 deleted the gr@improve-synthesis-error branch September 26, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message experience
4 participants