Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the "plonk" benchmarking #360

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

guorong009
Copy link

Description

Correct the plonk benchmarking code - prover and verifier bench

Related issues

  • None

Changes

  • set the number of instances in bench as 0

@guorong009 guorong009 self-assigned this Jul 22, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.64%. Comparing base (bc857a7) to head (3b7fd80).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files          84       84           
  Lines       17750    17750           
=======================================
  Hits        14670    14670           
  Misses       3080     3080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@guorong009 guorong009 marked this pull request as ready for review August 26, 2024 16:28
@guorong009 guorong009 merged commit 26fc7c2 into main Aug 26, 2024
19 checks passed
@guorong009 guorong009 deleted the gr@patch-bench-plonk branch August 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants