Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Assignment API errors #357

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

guorong009
Copy link

Description

Improve the Assignment API error messages by:

  • replace simple assertion with error return
  • use the cell name/description for better message

Related issues

Changes

  • create AssignmentError variant & enum for FrontendError enum
  • replace the assertion check with AssignmentError return in MockProver & WitnessCollection impls

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 15.10791% with 118 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (26fc7c2) to head (04d09b1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
halo2_frontend/src/plonk/error.rs 0.00% 64 Missing ⚠️
halo2_frontend/src/dev.rs 32.78% 41 Missing ⚠️
halo2_frontend/src/circuit.rs 7.14% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   82.64%   82.14%   -0.50%     
==========================================
  Files          84       84              
  Lines       17750    17870     +120     
==========================================
+ Hits        14669    14680      +11     
- Misses       3081     3190     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guorong009 guorong009 marked this pull request as ready for review September 16, 2024 02:48
Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guorong009 guorong009 merged commit 4cf2a70 into main Sep 18, 2024
19 checks passed
@guorong009 guorong009 deleted the gr@improve-assignment-api-errors branch September 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cell name to assertion errors of APIs like assign_advice, assign_fixed, etc.
3 participants