forked from zcash/halo2
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Expression copiable using singleton arena #354
Open
adria0
wants to merge
8
commits into
main
Choose a base branch
from
experimental/nocopy1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adria0
force-pushed
the
experimental/nocopy1
branch
from
June 17, 2024 14:01
ca5719e
to
c8c7ff9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 82.09% 81.81% -0.29%
==========================================
Files 83 83
Lines 17228 17452 +224
==========================================
+ Hits 14143 14278 +135
- Misses 3085 3174 +89 ☔ View full report in Codecov by Sentry. |
adria0
force-pushed
the
experimental/nocopy1
branch
from
June 17, 2024 15:05
c8c7ff9
to
09aa0b0
Compare
adria0
force-pushed
the
experimental/nocopy1
branch
from
June 17, 2024 15:13
09aa0b0
to
8d1a0c7
Compare
adria0
changed the title
[WIP] Make Expression copiable
[WIP] Make Expression copiable using singleton arena
Jun 17, 2024
…into experimental/nocopy1
adria0
changed the title
[WIP] Make Expression copiable using singleton arena
Make Expression copiable using singleton arena
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Relevant files to review are
halo2_frontend/src/plonk/circuit/{expession.rs, arena.rs}
This an experiment about making expression copiable. To implement this we go with this strategy:
ExprRef<F>
that contains the index (usize) of an expression stored in an specific arena.Expression
to useExprRef
instead the a recursiveExpression
that makes it non-copiable.FieldFront
. Mainly we change all frontend fromField
toFieldFront
, making arena accessible everywhere.This means:
<Field>
for<FieldFront>
and automatically all theirExpressions
are automatically copiable. This is thread-safe.