Skip to content

value coverage

value coverage #17

Triggered via push May 20, 2024 09:37
Status Success
Total duration 5m 32s
Artifacts

coverage.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

24 warnings
unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used: halo2_frontend/src/dev/tfp.rs#L227
warning: unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used --> halo2_frontend/src/dev/tfp.rs:227:5 | 227 | / value.value().assert_if_known(|v| { 228 | | debug!(target: "assigned", value = ?v); 229 | | true 230 | | }); | |______^ | help: use `let _ = ...` to ignore the resulting value | 227 | let _ = value.value().assert_if_known(|v| { | +++++++
unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used: halo2_frontend/src/circuit/value.rs#L792
warning: unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used --> halo2_frontend/src/circuit/value.rs:792:9 | 792 | V::known(1).assert_if_known(|v| *v == 2); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: use `let _ = ...` to ignore the resulting value | 792 | let _ = V::known(1).assert_if_known(|v| *v == 2); | +++++++
unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used: halo2_frontend/src/circuit/value.rs#L786
warning: unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used --> halo2_frontend/src/circuit/value.rs:786:9 | 786 | V::unknown().assert_if_known(|v| *v == 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: use `let _ = ...` to ignore the resulting value | 786 | let _ = V::unknown().assert_if_known(|v| *v == 1); | +++++++
unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used: halo2_frontend/src/circuit/value.rs#L785
warning: unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used --> halo2_frontend/src/circuit/value.rs:785:9 | 785 | V::known(1).assert_if_known(|v| *v == 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: use `let _ = ...` to ignore the resulting value | 785 | let _ = V::known(1).assert_if_known(|v| *v == 1); | +++++++
unused return value of `circuit::value::Value::<V>::map` that must be used: halo2_frontend/src/circuit/value.rs#L778
warning: unused return value of `circuit::value::Value::<V>::map` that must be used --> halo2_frontend/src/circuit/value.rs:778:9 | 778 | v_none.as_mut().map(|v| *v=3); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: use `let _ = ...` to ignore the resulting value | 778 | let _ = v_none.as_mut().map(|v| *v=3); | +++++++
unused return value of `circuit::value::Value::<V>::map` that must be used: halo2_frontend/src/circuit/value.rs#L777
warning: unused return value of `circuit::value::Value::<V>::map` that must be used --> halo2_frontend/src/circuit/value.rs:777:9 | 777 | v_some.as_mut().map(|v| *v=3); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 777 | let _ = v_some.as_mut().map(|v| *v=3); | +++++++
needlessly taken reference of both operands: halo2_frontend/src/circuit/value.rs#L877
warning: needlessly taken reference of both operands --> halo2_frontend/src/circuit/value.rs:877:20 | 877 | assert_eq!(&V::known(5) * &V::known(2), V::known(10)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 877 | assert_eq!(V::known(5) * V::known(2), V::known(10)); | ~~~~~~~~~~~ ~~~~~~~~~~~
taken reference of right operand: halo2_frontend/src/circuit/value.rs#L876
warning: taken reference of right operand --> halo2_frontend/src/circuit/value.rs:876:20 | 876 | assert_eq!(V::known(5) * &V::known(2), V::known(10)); | ^^^^^^^^^^^^^^------------ | | | help: use the right value directly: `V::known(2)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
needlessly taken reference of left operand: halo2_frontend/src/circuit/value.rs#L875
warning: needlessly taken reference of left operand --> halo2_frontend/src/circuit/value.rs:875:20 | 875 | assert_eq!(&V::known(5) * V::known(2), V::known(10)); | ------------^^^^^^^^^^^^^^ | | | help: use the left value directly: `V::known(5)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
needlessly taken reference of both operands: halo2_frontend/src/circuit/value.rs#L872
warning: needlessly taken reference of both operands --> halo2_frontend/src/circuit/value.rs:872:20 | 872 | assert_eq!(&V::known(5) - &V::known(2), V::known(3)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 872 | assert_eq!(V::known(5) - V::known(2), V::known(3)); | ~~~~~~~~~~~ ~~~~~~~~~~~
taken reference of right operand: halo2_frontend/src/circuit/value.rs#L871
warning: taken reference of right operand --> halo2_frontend/src/circuit/value.rs:871:20 | 871 | assert_eq!(V::known(5) - &V::known(2), V::known(3)); | ^^^^^^^^^^^^^^------------ | | | help: use the right value directly: `V::known(2)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
needlessly taken reference of left operand: halo2_frontend/src/circuit/value.rs#L870
warning: needlessly taken reference of left operand --> halo2_frontend/src/circuit/value.rs:870:20 | 870 | assert_eq!(&V::known(5) - V::known(2), V::known(3)); | ------------^^^^^^^^^^^^^^ | | | help: use the left value directly: `V::known(5)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
needlessly taken reference of both operands: halo2_frontend/src/circuit/value.rs#L867
warning: needlessly taken reference of both operands --> halo2_frontend/src/circuit/value.rs:867:20 | 867 | assert_eq!(&V::known(5) + &V::known(2), V::known(7)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 867 | assert_eq!(V::known(5) + V::known(2), V::known(7)); | ~~~~~~~~~~~ ~~~~~~~~~~~
taken reference of right operand: halo2_frontend/src/circuit/value.rs#L866
warning: taken reference of right operand --> halo2_frontend/src/circuit/value.rs:866:20 | 866 | assert_eq!(V::known(5) + &V::known(2), V::known(7)); | ^^^^^^^^^^^^^^------------ | | | help: use the right value directly: `V::known(2)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
needlessly taken reference of left operand: halo2_frontend/src/circuit/value.rs#L865
warning: needlessly taken reference of left operand --> halo2_frontend/src/circuit/value.rs:865:20 | 865 | assert_eq!(&V::known(5) + V::known(2), V::known(7)); | ------------^^^^^^^^^^^^^^ | | | help: use the left value directly: `V::known(5)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-W clippy::op-ref` implied by `-W clippy::all`
this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]`: halo2_frontend/src/circuit/value.rs#L91
warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` --> halo2_frontend/src/circuit/value.rs:91:5 | 91 | pub fn error_if_known_and<F: FnOnce(&V) -> bool>(&self, f: F) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: either add some descriptive text or remove the attribute = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use
this unit-returning function has a `#[must_use]` attribute: halo2_frontend/src/circuit/value.rs#L80
warning: this unit-returning function has a `#[must_use]` attribute --> halo2_frontend/src/circuit/value.rs:80:5 | 79 | #[must_use] | ----------- help: remove the attribute 80 | pub fn assert_if_known<F: FnOnce(&V) -> bool>(&self, f: F) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_unit = note: `-W clippy::must-use-unit` implied by `-W clippy::all`
this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]`: halo2_frontend/src/circuit/value.rs#L51
warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` --> halo2_frontend/src/circuit/value.rs:51:5 | 51 | pub fn assign(self) -> Result<V, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: either add some descriptive text or remove the attribute = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use = note: `-W clippy::double-must-use` implied by `-W clippy::all`
unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used: halo2_frontend/src/dev/tfp.rs#L227
warning: unused return value of `circuit::value::Value::<V>::assert_if_known` that must be used --> halo2_frontend/src/dev/tfp.rs:227:5 | 227 | / value.value().assert_if_known(|v| { 228 | | debug!(target: "assigned", value = ?v); 229 | | true 230 | | }); | |______^ | = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 227 | let _ = value.value().assert_if_known(|v| { | +++++++
this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]`: halo2_frontend/src/circuit/value.rs#L91
warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` --> halo2_frontend/src/circuit/value.rs:91:5 | 91 | pub fn error_if_known_and<F: FnOnce(&V) -> bool>(&self, f: F) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: either add some descriptive text or remove the attribute = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use
this unit-returning function has a `#[must_use]` attribute: halo2_frontend/src/circuit/value.rs#L80
warning: this unit-returning function has a `#[must_use]` attribute --> halo2_frontend/src/circuit/value.rs:80:5 | 79 | #[must_use] | ----------- help: remove the attribute 80 | pub fn assert_if_known<F: FnOnce(&V) -> bool>(&self, f: F) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_unit = note: `-W clippy::must-use-unit` implied by `-W clippy::all`
this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]`: halo2_frontend/src/circuit/value.rs#L51
warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` --> halo2_frontend/src/circuit/value.rs:51:5 | 51 | pub fn assign(self) -> Result<V, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: either add some descriptive text or remove the attribute = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use = note: `-W clippy::double-must-use` implied by `-W clippy::all`
coverage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/