[WIP] Refactor PDE operator for multigrid #401
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landinjm
force-pushed
the
refactor_PDE_operator
branch
from
90eaee1 to
f0f68f6
Compare
…ect should be its own class like we do for conditional ostreams. There are still somes cases where std::cout should be replaced with the pout_base of an assertion
|
|
|
Checklist of features left to integrate
|
Broke solveIncrement into four smaller sections: 1. Aux vars that are not nonlinear (sequential) 2. Explicit vars (concurrent) 3. Linear solves (sequential) 4. Nonlinear solve (concurrent) TODO/NOTES: I broke the skip_time_dependent thing. Changes not yet propogated. Need some documentation. Prefer to pass var_index into solver rather than use member variable currentFieldIndex. Maybe removed need for member variable currentIncrement. computeExplicitRHS-like functions are commented with "HERE" to be replaced
…haseField into refactor_PDE_operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not review. Posted to collaborate with @fractalsbyx.
Refactoring matrix free operator (in
computeRHSand etc.) to support multigrid and GPU.Summary of issues that are closed:
#394,
Issues in progress
#393
#398
#386
#376
#351
#346
#323
#313
#311
#301
#294
#291
#290
#285
#276
#273
#253
#218
#210
#174
#90
#86
#65