Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-2394] fix: prevent old onboarding from flashing when complete #1478

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

jomifepe
Copy link
Contributor

@jomifepe jomifepe commented Nov 5, 2024

Resolves: DT-2394

Preview

Kapture.2024-11-05.at.17.40.51.mp4

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@jomifepe jomifepe self-assigned this Nov 5, 2024
@jomifepe jomifepe requested a review from a team as a code owner November 5, 2024 17:41
Copy link

linear bot commented Nov 5, 2024

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Nov 6, 2024 11:41am

Copy link
Contributor

@BohdanOne BohdanOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM!

@dani-mp
Copy link
Contributor

dani-mp commented Nov 6, 2024

@BohdanOne we changed the approach to avoid some hacks, could you take another look?

Copy link
Contributor

@BohdanOne BohdanOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jomifepe jomifepe merged commit 771fb07 into main Nov 6, 2024
33 checks passed
@jomifepe jomifepe deleted the jp/DT-2394-flashing-ob-guide branch November 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants