feat: repeatable links code snippets #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dani-mp
changed the title
jomifepe
approved these changes
Nov 12, 2024
jomifepe
reviewed
Nov 12, 2024
Comment on lines
+73
to
+84
| } else if (repeat && !allowText) { | ||
| codeText = stripIndent` | ||
| <template v-for="(link, index) in ${dotPath(fieldPath)}" :key="index"> | ||
| <PrismicLink :field="link">Link</PrismicLink> | ||
| </template> | ||
| `; | ||
| } else if (repeat && allowText) { | ||
| codeText = stripIndent` | ||
| <template v-for="(link, index) in ${dotPath(fieldPath)}" :key="index"> | ||
| <PrismicLink :field="link" /> | ||
| </template> | ||
| `; |
There was a problem hiding this comment.
Not sure why, but I wasn't able to see the correct snippet with repeat, does it work correctly for you?
Kapture.2024-11-12.at.10.22.41.mp4
I can see it for Next and Sveltekit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
https://linear.app/prismic/issue/DT-2425/aauser-when-i-create-a-link-field-and-allow-repeatable-option-i-can
Description
allowTextandrepeatconfigs.repeatconfig changes.Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩