CNI - Allow usage of existing triggers w/ custom flow onInstanceDelete and onInstanceDeploy behavior #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avior and custom flow behavior
pattra
force-pushed
the
pa/instance-deploy-delete
branch
from
64c1806
to
bf427e1
Compare
bkegley
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a CNI set a flow's
onTriggerto a component reference and also definedonInstanceDeleteoronInstanceDeploybehavior, the flow'sonInstancemethods would be ignored.This PR makes it such that if a flow defines both a component reference
onTrigger(either explicitly or via default fallback) along withonInstancebehavior, all definedonInstancebehavior will execute.In the case of both the component & the flow having defined
onInstancebehavior (e.g. they each have their ownonInstanceDeploydefinitions), the returned responses will be deep-merged with preference given to the flow's response if there's a conflict.